cadonna commented on PR #19275: URL: https://github.com/apache/kafka/pull/19275#issuecomment-2909713453
Hi @janchilling , Sorry for the long silence but I was quite busy recently. Yeah, I agree with you about the bug regarding the state updater thread that is not torn down after the `IllegalStateException`. However, rather than surrounding the code in the `StreamThread#create()` with a `try-catch`-clause, I propose to create an `init()` method in the `TaskManager` that starts the state updater. The `init()` method is then called in the beginning of the `run()` method of the stream thread. In such a way we have starting and shutting down the state updater thread encapsulated in the `TaskManager` which ensures that the state updater thread it not started before the stream thread is started. Could you open a separate PR just for that? If that solves the issue, we would first merge that PR and then merge this PR on top of the that PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
