chia7712 commented on code in PR #19798:
URL: https://github.com/apache/kafka/pull/19798#discussion_r2106226720
##########
server-common/src/main/java/org/apache/kafka/server/purgatory/DelayedOperation.java:
##########
@@ -41,19 +40,10 @@ public abstract class DelayedOperation extends TimerTask {
private volatile boolean completed = false;
- protected final Lock lock;
-
- public DelayedOperation(long delayMs, Optional<Lock> lockOpt) {
- this(delayMs, lockOpt.orElse(new ReentrantLock()));
- }
+ protected final Lock lock = new ReentrantLock();
Review Comment:
Could you please change the type from `Lock` to `ReentrantLock`? This class
requires some features of `ReentrantLock`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
