lucasbru commented on code in PR #19717:
URL: https://github.com/apache/kafka/pull/19717#discussion_r2093505491
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##########
@@ -671,8 +672,9 @@ private LogOffsetMetadata fetchLastStableOffsetMetadata()
throws IOException {
* beyond the high watermark.
*/
public long lastStableOffset() {
- if (firstUnstableOffsetMetadata.isPresent() &&
firstUnstableOffsetMetadata.get().messageOffset < highWatermark()) {
- return firstUnstableOffsetMetadata.get().messageOffset;
+ Optional<LogOffsetMetadata> firstUnstableOffsetMetadataCopy =
firstUnstableOffsetMetadata;
Review Comment:
Done
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##########
@@ -647,8 +647,9 @@ private LogOffsetMetadata fetchLastStableOffsetMetadata()
throws IOException {
// cache the current high watermark to avoid a concurrent update
invalidating the range check
LogOffsetMetadata highWatermarkMetadata = fetchHighWatermarkMetadata();
- if (firstUnstableOffsetMetadata.isPresent() &&
firstUnstableOffsetMetadata.get().messageOffset <
highWatermarkMetadata.messageOffset) {
- LogOffsetMetadata lom = firstUnstableOffsetMetadata.get();
+ Optional<LogOffsetMetadata> firstUnstableOffsetMetadataCopy =
firstUnstableOffsetMetadata;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
