apoorvmittal10 commented on code in PR #19661:
URL: https://github.com/apache/kafka/pull/19661#discussion_r2084666608
##########
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java:
##########
@@ -149,10 +144,29 @@ public void testIterator(Args args) {
new SimpleRecord(6L, (byte[]) null, null)
};
- for (SimpleRecord record : records)
- builder.append(record);
+ final MemoryRecords memoryRecords;
+ try (var builder = new MemoryRecordsBuilder(
+ buffer,
+ magic,
+ compression,
+ TimestampType.CREATE_TIME,
+ firstOffset,
+ logAppendTime,
+ pid,
+ epoch,
+ firstSequence,
+ false,
+ false,
+ partitionLeaderEpoch, buffer.limit()
Review Comment:
nit: as like other params.
```suggestion
partitionLeaderEpoch,
buffer.limit()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
