omkreddy commented on code in PR #19622:
URL: https://github.com/apache/kafka/pull/19622#discussion_r2078936871
##########
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/DefaultJwtRetriever.java:
##########
@@ -36,32 +39,27 @@
import static
org.apache.kafka.common.security.oauthbearer.OAuthBearerLoginCallbackHandler.CLIENT_SECRET_CONFIG;
import static
org.apache.kafka.common.security.oauthbearer.OAuthBearerLoginCallbackHandler.SCOPE_CONFIG;
-public class AccessTokenRetrieverFactory {
+public class DefaultJwtRetriever implements JwtRetriever {
Review Comment:
Can we add Javadoc?
##########
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/OAuthBearerLoginCallbackHandler.java:
##########
@@ -177,57 +178,41 @@ public class OAuthBearerLoginCallbackHandler implements
AuthenticateCallbackHand
private static final String EXTENSION_PREFIX = "extension_";
- private Map<String, Object> moduleOptions;
+ protected Map<String, Object> moduleOptions;
Review Comment:
Can we avoid protected in these public classes. maybe we can add
package-private getters/etc.. for testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
