rreddy-22 commented on code in PR #19539:
URL: https://github.com/apache/kafka/pull/19539#discussion_r2078931303
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -330,6 +334,17 @@ public synchronized void beginTransaction() {
transitionTo(State.IN_TRANSACTION);
}
+ /**
+ * Begin preparing a transaction for a two-phase commit.
+ * This transitions the transaction to the PREPARING_TRANSACTION state.
+ */
+ public synchronized void beginPrepare() {
+ ensureTransactional();
+ throwIfPendingState("prepareTransaction");
+ maybeFailWithError();
+ transitionTo(State.PREPARING_TRANSACTION);
Review Comment:
Yes, I added this code in the InitProducerIdHandler, unless you meant
something else
> // If this is a 2PC-enabled transaction with keepPreparedTxn=true,
transition directly
> // to PREPARED_TRANSACTION
> if (enable2PC && builder.data.keepPreparedTxn()) {
> transitionTo(State.PREPARED_TRANSACTION);
> } else {
> transitionTo(State.READY);
> }
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
