junrao commented on code in PR #19635:
URL: https://github.com/apache/kafka/pull/19635#discussion_r2078086943
##########
core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala:
##########
@@ -978,15 +1015,19 @@ class AuthorizerIntegrationTest extends
AbstractAuthorizerIntegrationTest {
* even if the topic doesn't exist, request APIs should not leak the topic
name
*/
@ParameterizedTest
- @ValueSource(strings = Array("kraft"))
- def testAuthorizationFetchV12WithTopicNotExisting(quorum: String): Unit = {
+ @CsvSource(value = Array("false", "true"))
+ def testAuthorizationFetchV12WithTopicNotExisting(withTopicExisting:
Boolean): Unit = {
Review Comment:
Could we adjust the test name now that it also tests the topic existing case?
##########
core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala:
##########
@@ -978,15 +1015,19 @@ class AuthorizerIntegrationTest extends
AbstractAuthorizerIntegrationTest {
* even if the topic doesn't exist, request APIs should not leak the topic
name
*/
@ParameterizedTest
- @ValueSource(strings = Array("kraft"))
- def testAuthorizationFetchV12WithTopicNotExisting(quorum: String): Unit = {
+ @CsvSource(value = Array("false", "true"))
Review Comment:
Could we adjust the comment above to sth like "Test that the fetch request
fails with TOPIC_AUTHORIZATION_FAILED if the client doesn't have permission and
topic name is used in the request. Even if the topic doesn't exist, we return
TOPIC_AUTHORIZATION_FAILED to prevent leaking the topic name."? Ditto for
`testAuthorizationForProduceRequestVersionLessThan13`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
