ableegoldman commented on code in PR #19400:
URL: https://github.com/apache/kafka/pull/19400#discussion_r2071532836
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -1776,22 +1780,28 @@ private long advanceNowAndComputeLatency() {
return Math.max(now - previous, 0);
}
+ public void shutdown() {
Review Comment:
as mentioned above, let's just get rid of the overload without a
`leaveGroup` parameter, this way the caller has to consciously decide whether
it should be leaving the group or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
