dajac commented on code in PR #19605:
URL: https://github.com/apache/kafka/pull/19605#discussion_r2068843867


##########
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##########
@@ -192,7 +192,8 @@ public class CommonClientConfigs {
                                                           + "is considered 
failed and the group will rebalance in order to reassign the partitions to 
another member. "
                                                           + "For consumers 
using a non-null <code>group.instance.id</code> which reach this timeout, 
partitions will not be immediately reassigned. "
                                                           + "Instead, the 
consumer will stop sending heartbeats and partitions will be reassigned "
-                                                          + "after expiration 
of <code>session.timeout.ms</code>. This mirrors the behavior of a static 
consumer which has shutdown.";
+                                                          + "after expiration 
of the session timeout (defined by <code>session.timeout.ms</code> if using the 
Classic rebalance protocol, or by 
<code>group.consumer.session.timeout.ms</code> if using the Consumer protocol). 
"

Review Comment:
   Should we mention that `group.consumer.session.timeout.ms` is defined on the 
server?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to