jsancio commented on code in PR #19596:
URL: https://github.com/apache/kafka/pull/19596#discussion_r2067345623
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -204,38 +207,42 @@ object DynamicBrokerConfig {
props.put(key, value)
}
}
- raftManager.replicatedLog.latestSnapshotId().ifPresent(latestSnapshotId =>
{
-
raftManager.replicatedLog.readSnapshot(latestSnapshotId).ifPresent(rawSnapshotReader
=> {
- val reader = RecordsSnapshotReader.of(
- rawSnapshotReader,
- raftManager.recordSerde,
- BufferSupplier.create(),
- KafkaRaftClient.MAX_BATCH_SIZE_BYTES,
- true
- )
- val dynamicPerBrokerConfigs = new Properties()
- val dynamicDefaultConfigs = new Properties()
- while (reader.hasNext) {
- val batch = reader.next()
- batch.forEach(record => {
- if (record.message().apiKey() ==
MetadataRecordType.CONFIG_RECORD.id) {
- val configRecord = record.message().asInstanceOf[ConfigRecord]
- if
(DynamicBrokerConfig.AllDynamicConfigs.contains(configRecord.name()) &&
- configRecord.resourceType() ==
ConfigResource.Type.BROKER.id()) {
- if (configRecord.resourceName().isEmpty) {
- putOrRemoveIfNull(dynamicDefaultConfigs,
configRecord.name(), configRecord.value())
- } else if (configRecord.resourceName() ==
config.brokerId.toString) {
- putOrRemoveIfNull(dynamicPerBrokerConfigs,
configRecord.name(), configRecord.value())
- }
+ raftManager.replicatedLog.latestSnapshotId().ifPresent { latestSnapshotId
=>
+ raftManager.replicatedLog.readSnapshot(latestSnapshotId).ifPresent {
rawSnapshotReader =>
+ Using.resource(
+ RecordsSnapshotReader.of(
+ rawSnapshotReader,
+ raftManager.recordSerde,
+ BufferSupplier.create(),
+ KafkaRaftClient.MAX_BATCH_SIZE_BYTES,
+ true,
+ logContext
+ )
+ ) { reader =>
Review Comment:
This wasn't closing the snapshot reader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
