CalvinConfluent commented on code in PR #19355: URL: https://github.com/apache/kafka/pull/19355#discussion_r2066815028
########## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListTransactionsHandler.java: ########## @@ -75,6 +75,9 @@ public ListTransactionsRequest.Builder buildBatchedRequest( .map(TransactionState::toString) .collect(Collectors.toList())); request.setDurationFilter(options.filteredDuration()); + if (!options.filteredTransactionalIdPattern().isEmpty()) { Review Comment: For the filteredTransactionalIdPattern in the ListTransactionsOptions, the default value is "" and we only update it if the user sets the `--transactional-id-pattern`. It should be valid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org