mjsax commented on code in PR #19570:
URL: https://github.com/apache/kafka/pull/19570#discussion_r2061122049


##########
streams/src/test/java/org/apache/kafka/streams/kstream/SessionWindowedDeserializerTest.java:
##########
@@ -44,37 +44,44 @@ public void testSessionWindowedDeserializerConstructor() {
         assertInstanceOf(StringDeserializer.class, inner, "Inner deserializer 
type should be StringDeserializer");
     }
 
+    @Deprecated
     @Test
     public void shouldSetSerializerThroughWindowedInnerClassSerdeConfig() {
         props.put(StreamsConfig.WINDOWED_INNER_CLASS_SERDE, 
Serdes.ByteArraySerde.class.getName());
-        final SessionWindowedDeserializer<?> deserializer = new 
SessionWindowedDeserializer<>();
-        deserializer.configure(props, false);
-        assertInstanceOf(ByteArrayDeserializer.class, 
deserializer.innerDeserializer());
+        try (final SessionWindowedDeserializer<?> deserializer = new 
SessionWindowedDeserializer<>()) {

Review Comment:
   Fixing "resource" warning for `Closable`. Similar elsewhere.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to