m1a2st commented on code in PR #19527:
URL: https://github.com/apache/kafka/pull/19527#discussion_r2061114438
##########
clients/src/main/java/org/apache/kafka/common/security/authenticator/LoginManager.java:
##########
@@ -53,20 +56,30 @@ public class LoginManager {
// dynamic configs (broker or client)
private static final Map<LoginMetadata<Password>, LoginManager>
DYNAMIC_INSTANCES = new HashMap<>();
- private final Login login;
+ private final Plugin<Login> loginPlugin;
private final LoginMetadata<?> loginMetadata;
private final AuthenticateCallbackHandler loginCallbackHandler;
private int refCount;
- private LoginManager(JaasContext jaasContext, String saslMechanism,
Map<String, ?> configs,
- LoginMetadata<?> loginMetadata) throws LoginException {
+ private LoginManager(
+ JaasContext jaasContext,
+ String saslMechanism,
+ Map<String, ?> configs,
+ LoginMetadata<?> loginMetadata,
+ ConnectionMode connectionMode,
+ Metrics metrics
+ ) throws LoginException {
this.loginMetadata = loginMetadata;
- this.login = Utils.newInstance(loginMetadata.loginClass);
+ Login login = Utils.newInstance(loginMetadata.loginClass);
+ if (connectionMode == ConnectionMode.SERVER)
+ this.loginPlugin = Plugin.wrapInstance(login, metrics,
SaslConfigs.SASL_LOGIN_CLASS, "mechanism", saslMechanism);
Review Comment:
Yes, the metrics will conflict with this approach.
To avoid collisions, I think we can additional tags for both the listener
and SaslChannelBuilder:
- Listener tag: Use `listener-name` to record `ListenerName#value`.
- SASL channel tag: Use `sasl-channel` to record the name in the format
`SaslChannelBuilder- + i`.
Maybe it would be better to use a more meaningful value for
SaslChannelBuilder instead of just appending a numeric suffix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
