AndrewJSchofield commented on code in PR #19478:
URL: https://github.com/apache/kafka/pull/19478#discussion_r2059879931
##########
clients/src/main/java/org/apache/kafka/clients/admin/Admin.java:
##########
@@ -1954,11 +1954,11 @@ default ListShareGroupOffsetsResult
listShareGroupOffsets(Map<String, ListShareG
* Delete offsets for a set of partitions in a share group.
Review Comment:
This is now "set of topics".
##########
clients/src/main/java/org/apache/kafka/clients/admin/Admin.java:
##########
@@ -1954,11 +1954,11 @@ default ListShareGroupOffsetsResult
listShareGroupOffsets(Map<String, ListShareG
* Delete offsets for a set of partitions in a share group.
*
* @param groupId The group for which to delete offsets.
- * @param partitions The topic-partitions.
+ * @param topics The set of topic names for which offsets need to be
deleted.
* @param options The options to use when deleting offsets in a share
group.
* @return The DeleteShareGroupOffsetsResult.
*/
- DeleteShareGroupOffsetsResult deleteShareGroupOffsets(String groupId,
Set<TopicPartition> partitions, DeleteShareGroupOffsetsOptions options);
+ DeleteShareGroupOffsetsResult deleteShareGroupOffsets(String groupId,
Set<String> topics, DeleteShareGroupOffsetsOptions options);
/**
* Delete offsets for a set of partitions in a share group with the
default options.
Review Comment:
And here "set of topics" too.
##########
clients/src/main/java/org/apache/kafka/clients/admin/Admin.java:
##########
@@ -1968,11 +1968,11 @@ default ListShareGroupOffsetsResult
listShareGroupOffsets(Map<String, ListShareG
* See the overload for more details.
*
* @param groupId The group for which to delete offsets.
- * @param partitions The topic-partitions.
+ * @param topics The set of topic names for which offsets need to be
deleted.
Review Comment:
And here "The topics for which to delete offsets."
##########
clients/src/main/java/org/apache/kafka/clients/admin/Admin.java:
##########
@@ -1954,11 +1954,11 @@ default ListShareGroupOffsetsResult
listShareGroupOffsets(Map<String, ListShareG
* Delete offsets for a set of partitions in a share group.
*
* @param groupId The group for which to delete offsets.
- * @param partitions The topic-partitions.
+ * @param topics The set of topic names for which offsets need to be
deleted.
Review Comment:
Let's just have "The topics for which to delete offsets."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
