mjsax commented on code in PR #19507:
URL: https://github.com/apache/kafka/pull/19507#discussion_r2059536918
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -552,8 +552,14 @@ private void handleTasksWithStateUpdater(final Map<TaskId,
Set<TopicPartition>>
private void handleTasksPendingInitialization() {
// All tasks pending initialization are not part of the usual
bookkeeping
+
+ final Set<Task> tasksToCloseDirty = new HashSet<>();
+
for (final Task task : tasks.drainPendingTasksToInit()) {
- closeTaskClean(task, Collections.emptySet(),
Collections.emptyMap());
+ closeTaskClean(task, tasksToCloseDirty, new HashMap<>());
+ }
+ for (final Task task : tasksToCloseDirty) {
+ closeTaskDirty(task, false);
Review Comment:
Not 100% sure if we need to pass `true` or `false` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
