jolshan commented on code in PR #19522:
URL: https://github.com/apache/kafka/pull/19522#discussion_r2058859436
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -1073,6 +1074,11 @@ private void transitionTo(State target, RuntimeException
error) {
} else if (target == State.FATAL_ERROR || target ==
State.ABORTABLE_ERROR) {
if (error == null)
throw new IllegalArgumentException("Cannot transition to " +
target + " with a null exception");
+
+ if (error instanceof RetriableException) {
+ error = new TransactionAbortableException("Transaction Request
was aborted after exhausting retries.", error);
+ }
+
Review Comment:
Are we also setting the current state to State.ABORTABLE_ERROR? It appears
that way in the test, but I wasn't sure where that mechanism was.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
