m1a2st commented on code in PR #19519:
URL: https://github.com/apache/kafka/pull/19519#discussion_r2057212084


##########
clients/src/test/java/org/apache/kafka/common/metrics/internals/PluginMetricsImplTest.java:
##########
@@ -36,11 +35,15 @@
 
 public class PluginMetricsImplTest {
 
-    private final Map<String, String> extraTags = 
Collections.singletonMap("my-tag", "my-value");
+    private static final LinkedHashMap<String, String> EXTRA_TAGS = new 
LinkedHashMap<>();

Review Comment:
   This change is not what I wanted—using `Map.of` does not preserve the order 
of entries as provided by the user.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to