chia7712 commented on code in PR #19536:
URL: https://github.com/apache/kafka/pull/19536#discussion_r2056430013


##########
clients/src/main/resources/common/message/ShareFetchResponse.json:
##########
@@ -67,7 +67,7 @@
           { "name": "LeaderEpoch", "type": "int32", "versions": "0+",
             "about": "The latest known leader epoch." }
         ]},
-        { "name": "Records", "type": "records", "versions": "0+", 
"nullableVersions": "0+", "about": "The record data." },
+        { "name": "Records", "type": "records", "versions": "0+", "about": 
"The record data." },

Review Comment:
   the v0 is not available for now, so it should be fine to remove 
`nullableVersions`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to