Rancho-7 commented on PR #19529: URL: https://github.com/apache/kafka/pull/19529#issuecomment-2824772465
> Thanks for the PR. Could you also refactor Vector as ArrayList in > > https://github.com/apache/kafka/blob/18584b11ecbb364428da5d0316a23008ff6e8cd9/connect/mirror/src/test/java/org/apache/kafka/connect/mirror/clients/admin/FakeLocalMetadataStore.java#L115 > > Thanks. @FrankYang0529 Thanks for the suggestion! I just have one concern — in our current test setup,both the [`primary`](https://github.com/apache/kafka/blob/efd785274e7c6dd75a3286ca6da1379830366acc/connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java#L208) and [`backup`](https://github.com/apache/kafka/blob/efd785274e7c6dd75a3286ca6da1379830366acc/connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java#L218) clusters use [3 connector workers](https://github.com/apache/kafka/blob/efd785274e7c6dd75a3286ca6da1379830366acc/connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java#L126) each. Since `ArrayList` isn't thread safe,do you think this change could introduce any concurrency issues in this context? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
