jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2050817961
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -2435,8 +2434,18 @@ private boolean handleUpdateVoterResponse(
responseMetadata.source(),
currentTimeMs
);
+ if (handled.isPresent()) {
Review Comment:
Good catch. That predicate is wrong. It should be
`responseLeaderId.isPresent() && !data.currentLeader().host().isEmpty()`. I
really need add [tests](https://issues.apache.org/jira/browse/KAFKA-19175) to
make sure that kraft correctly handles the leader endpoints in all of the
responses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
