dajac commented on code in PR #19509: URL: https://github.com/apache/kafka/pull/19509#discussion_r2050307207
########## server-common/src/main/java/org/apache/kafka/server/common/StreamsGroupVersion.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.common; + +import java.util.Map; + +public enum StreamsGroupVersion implements FeatureVersion { + + // Version 0 does disable "streams" groups (KIP-1071). + SGV_0(0, MetadataVersion.MINIMUM_VERSION, Map.of()), + + // Version 1 enables "streams" groups (KIP-1071). + SGV_1(1, MetadataVersion.IBP_4_1_IV2, Map.of()); Review Comment: Using IBP_4_1_IV2 means that it will be enabled by default when the cluster is upgraded to 4.1. I am not sure that this is what you want based on the description of the PR. ########## server-common/src/main/java/org/apache/kafka/server/common/StreamsGroupVersion.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.common; + +import java.util.Map; + +public enum StreamsGroupVersion implements FeatureVersion { + + // Version 0 does disable "streams" groups (KIP-1071). + SGV_0(0, MetadataVersion.MINIMUM_VERSION, Map.of()), + + // Version 1 enables "streams" groups (KIP-1071). + SGV_1(1, MetadataVersion.IBP_4_1_IV2, Map.of()); + + public static final String FEATURE_NAME = "streams.group.version"; + + // Disabled by default in 4.1 (early access only). + public static final StreamsGroupVersion LATEST_PRODUCTION = SGV_0; Review Comment: This does not mean "disabled by default". It means that you can not use it unless "unstable features" are allowed. ########## server-common/src/main/java/org/apache/kafka/server/common/StreamsGroupVersion.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.common; + +import java.util.Map; + +public enum StreamsGroupVersion implements FeatureVersion { + + // Version 0 does disable "streams" groups (KIP-1071). + SGV_0(0, MetadataVersion.MINIMUM_VERSION, Map.of()), + + // Version 1 enables "streams" groups (KIP-1071). + SGV_1(1, MetadataVersion.IBP_4_1_IV2, Map.of()); + + public static final String FEATURE_NAME = "streams.group.version"; Review Comment: I would use `streams.version` to be consistent with the other ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
