m1a2st commented on code in PR #19479:
URL: https://github.com/apache/kafka/pull/19479#discussion_r2045944677
##########
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##########
@@ -58,8 +58,10 @@ public class TopicConfig {
public static final String FLUSH_MS_CONFIG = "flush.ms";
public static final String FLUSH_MS_DOC = "This setting allows specifying
a time interval at which we will " +
"force an fsync of data written to the log. For example if this was
set to 1000 " +
- "we would fsync after 1000 ms had passed. In general we recommend you
not set " +
- "this and use replication for durability and allow the operating
system's background " +
+ "we would fsync after 1000 ms had passed. Note that this setting
depends on the broker-level " +
+ "configuration \"log.flush.scheduler.interval.ms\", which controls how
frequently the flush check occurs. " +
+ "If \"log.flush.scheduler.interval.ms\" is not configured, the topic
config \"flush.ms\" will not be triggered. " +
Review Comment:
We can also use the `LOG_FLUSH_SCHEDULER_INTERVAL_MS_CONFIG` and
`FLUSH_MS_CONFIG` constants instead of hardcoding the strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
