frankvicky commented on code in PR #19472:
URL: https://github.com/apache/kafka/pull/19472#discussion_r2044320517
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/CleanerConfig.java:
##########
@@ -68,7 +69,8 @@ public class CleanerConfig {
public static final String LOG_CLEANER_DEDUPE_BUFFER_LOAD_FACTOR_DOC =
"Log cleaner dedupe buffer load factor. The percentage full the dedupe buffer
can become. A higher value " +
"will allow more log to be cleaned at once but will lead to more
hash collisions";
public static final String LOG_CLEANER_BACKOFF_MS_DOC = "The amount of
time to sleep when there are no logs to clean";
- public static final String LOG_CLEANER_ENABLE_DOC = "Enable the log
cleaner process to run on the server. Should be enabled if using any topics
with a cleanup.policy=compact including the internal offsets topic. If disabled
those topics will not be compacted and continually grow in size.";
+ public static final String LOG_CLEANER_ENABLE_DOC = "This configuration
has been deprecated and will be remove in Kafka 5.0. User shouldn't set it to
false anymore." +
Review Comment:
I will add a reference to KIP-1148. It should be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
