mjsax commented on code in PR #19394:
URL: https://github.com/apache/kafka/pull/19394#discussion_r2043220458


##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java:
##########
@@ -336,16 +339,20 @@ private void testShutdownApplication(final int 
numThreads) throws Exception {
         final Topology topology = builder.build();
 
         try (final KafkaStreams kafkaStreams1 = new KafkaStreams(topology, 
properties);
-             final KafkaStreams kafkaStreams2 = new KafkaStreams(topology, 
properties)) {
+             final KafkaStreams kafkaStreams2 = new KafkaStreams(topology, 
properties);

Review Comment:
   If we follow the idea from the other comment, we might want to pass in a 
`MockTime` object into `KafkaStreams` to not let time advance, and thus ensure 
we get the WARN log really only a single time?
   
   Or we would assert to get the log line less than 100 times (or something 
like this)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to