smjn commented on PR #19443: URL: https://github.com/apache/kafka/pull/19443#issuecomment-2802453814
> I've been playing with the code and generally it looks stable. However, I do observe that in a very quiet system, it will take snapshots every 5 minutes, even if that's all that it's doing. Surely, there comes a point where it's not worth writing a cold snapshot, because the amount of data to be replayed doesn't decrease at all by doing it. We can modify the logic to stop cold snapshotting if all existing share partitions are already snapshotted. This means that after last snapshot they have not been written to organically. so if we end up in state: ``` snap1-force snap2-organic snap3-force ``` cold snapshotting will happen at 5 minute intervals but if we end up with ``` snap1-force snap2-force snap3-force ``` cold snapshotting will stop -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
