rreddy-22 commented on code in PR #19364:
URL: https://github.com/apache/kafka/pull/19364#discussion_r2042633583
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -1520,6 +1520,10 @@ class KafkaApis(val requestChannel: RequestChannel,
requestHelper.sendErrorResponseMaybeThrottle(request,
Errors.TRANSACTIONAL_ID_AUTHORIZATION_FAILED.exception)
return
}
+ if (initProducerIdRequest.enable2Pc() &&
!authHelper.authorize(request.context, TWO_PHASE_COMMIT, TRANSACTIONAL_ID,
transactionalId)) {
+ requestHelper.sendErrorResponseMaybeThrottle(request,
Errors.TRANSACTIONAL_ID_AUTHORIZATION_FAILED.exception)
Review Comment:
@artemlivshits what are your thoughts on this? In my opinion, the
documentation for the exception is enough to see what ACL is missing. Do we
also want to include this information in the log, it doesn't seem like common
practice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
