[
https://issues.apache.org/jira/browse/KAFKA-7502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747025#comment-16747025
]
ASF GitHub Bot commented on KAFKA-7502:
---------------------------------------
dongjinleekr commented on pull request #6174: KAFKA-7502: Cleanup KTable
materialization logic in a single place
URL: https://github.com/apache/kafka/pull/6174
This is a draft cleanup for KAFKA-7502. Here is the details:
1. Make `KTableKTableJoinNode` abstract, and define its child classes
(`[NonMaterialized,Materialized]KTableKTableJoinNode`) instead: now, all
materialization-related routines are separated into the other classes.
2. `KTableKTableJoinNodeBuilder#build` now instantiates
`[NonMaterialized,Materialized]KTableKTableJoinNode` classes instead of
`KTableKTableJoinNode`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cleanup KTable materialization logic in a single place
> ------------------------------------------------------
>
> Key: KAFKA-7502
> URL: https://issues.apache.org/jira/browse/KAFKA-7502
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Guozhang Wang
> Priority: Minor
>
> Today since we pre-create all the `KTableXXX` operator along with the logical
> node, we are effectively duplicating the logic to determine whether the
> resulted KTable should be materialized. For example, in
> `KTableKTableJoinNode` and in `KTableImpl#doJoin`. This is bug-vulnerable
> since we may update the logic in one class but forgot to update the other
> class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
