chia7712 commented on code in PR #19366:
URL: https://github.com/apache/kafka/pull/19366#discussion_r2027583667
##########
clients/src/main/java/org/apache/kafka/clients/consumer/AcknowledgementCommitCallback.java:
##########
@@ -34,6 +34,7 @@
* The callback may be executed in any thread calling {@link
ShareConsumer#poll(java.time.Duration)}.
*/
@InterfaceStability.Evolving
+@FunctionalInterface
Review Comment:
> but I just think that the word "callback" itself implies some form of
"response handler" function. I will stay within Kafka's nomenclature, I just
thought that that was more or less the terminology.
yes, I agree that. My point was the interface is in evolving, so it is not
urgent to add the annotation for now. However, that is personal taste rather
than strong reason. We can add the annotation after it is in stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
