Tombert commented on PR #19234: URL: https://github.com/apache/kafka/pull/19234#issuecomment-2774109863
> Thanks for the update. Think you got a few to many now. Let me clarify further. > > For `kstream` package, I think it's correct (except the few too many I mentioned on the other comment). > > For `processor.api`, I am wondering if we should add `ContextualFixedKeyProcessor` and `ContextualProcessor` (both are classes, but I think they still qualify?). -- We should also add `FixedKeyProcessorSupplier` and `ProcessorSupplier`. > > In `processor` I think we should add `CommitCallback`. > > Everything else look right. Sorry for not being more specific in my more review; thought you would figure it out on your own. I don't think you can do the @FunctionalInterface on classes. When i try doing that intellij blows up on me. I think CommitCallback was already annotated: https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/processor/CommitCallback.java#L28 I did add OffsetCommitCallback, since I think "Callback" sort of implies functional interface, but I can change it if you think I'm wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
