apalan60 commented on code in PR #19342:
URL: https://github.com/apache/kafka/pull/19342#discussion_r2025288103
##########
clients/src/main/java/org/apache/kafka/common/record/RecordVersion.java:
##########
@@ -20,8 +20,7 @@
* Defines the record format versions supported by Kafka.
*
* For historical reasons, the record format version is also known as `magic`
and `message format version`. Note that
- * the version actually applies to the {@link RecordBatch} (instead of the
{@link Record}). Finally, the
- * `message.format.version` topic config confusingly expects an ApiVersion
instead of a RecordVersion.
+ * the version actually applies to the {@link RecordBatch} (instead of the
{@link Record}).
*/
public enum RecordVersion {
V0(0), V1(1), V2(2);
Review Comment:
@m1a2st
Thanks for your review.
> It seems `precedes()` is unused in production code, may be we can remove
it.
Yes, this is an unused method. I checked the git log, and it turns out that
the classes which previously called it have been removed. I have therefore
removed it as part of this PR. PTAL, Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
