lianetm commented on PR #19298: URL: https://github.com/apache/kafka/pull/19298#issuecomment-2772728528
Hey @m1a2st , thanks for the patch! Haven't looked into the code in detail yet, but high level comments: 1. The new test is being added outside of the `consumer` folder, is that intentional? Seems confusing, this test is solely about consumer callbacks (and I expect we don't want to group together consumer and producer callback tests here right?) 2. Do we need the extra grouping/folder `callback`? I wonder if it will fire back at us when migrating the rest of the multiple PlaintextConsumerXXX files we have (would we end up with specific folders for each?) Seems like too much nesting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
