davide-armand commented on PR #18142: URL: https://github.com/apache/kafka/pull/18142#issuecomment-2771640033
> Hi @davide-armand Thanks for the fix, and thanks for the test! > > Are you able to remove the Thread.sleep calls from the test? These could introduce some flakiness later if run on slow machines. Additionally I think this test leaks threads through the executors. Could you ensure that the executors are closed, and the threads terminate? @gharris1727 Pushed a fix in a separate commit, will squash before merging. I cannot get a green build, if I'm not mistaken it fails on unrelated tests. Should I keep restarting the CI hoping for a green build? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
