m1a2st commented on PR #19324:
URL: https://github.com/apache/kafka/pull/19324#issuecomment-2767729651

   Hello @mjsax. thanks for review
   
   > What do you mean by this? logs is part of .gitignore similar build/
   
   `filePattern: "streams-scala-%d{yyyy-MM-dd}.log"` this is leak, When I test 
on trunk, it will generate the `streams-scala` log file.
   
![image](https://github.com/user-attachments/assets/43ab45ac-635d-41a7-9308-17a91cbc8e03)
   
![image](https://github.com/user-attachments/assets/c25c54bc-30e7-4797-90ea-652bbc0280cf)
   
   > Also, comparing the log4j2.yaml with other in streams context, the other 
don't configure any file appender, so I am wondering if we should not just 
change the directory, but remove the file appender entirely?
   
   I'm not sure why we're using a file appender, but if we don't check the log 
files, removing the appender seems like a good approach.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to