chia7712 commented on code in PR #19325:
URL: https://github.com/apache/kafka/pull/19325#discussion_r2021388915
##########
clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java:
##########
@@ -67,11 +66,11 @@ public enum ApiKeys {
DELETE_RECORDS(ApiMessageType.DELETE_RECORDS),
INIT_PRODUCER_ID(ApiMessageType.INIT_PRODUCER_ID),
OFFSET_FOR_LEADER_EPOCH(ApiMessageType.OFFSET_FOR_LEADER_EPOCH),
- ADD_PARTITIONS_TO_TXN(ApiMessageType.ADD_PARTITIONS_TO_TXN, false,
RecordBatch.MAGIC_VALUE_V2, false),
- ADD_OFFSETS_TO_TXN(ApiMessageType.ADD_OFFSETS_TO_TXN, false,
RecordBatch.MAGIC_VALUE_V2, false),
- END_TXN(ApiMessageType.END_TXN, false, RecordBatch.MAGIC_VALUE_V2, false),
Review Comment:
> RecordVersion is the better option since it's actually type safe.
agree. not sure why we don't use `RecordVersion` in code base :(
> I noticed we can remove the following from its javadoc though:
Do you plan to fix it in this PR? or I can file another one to address this
small cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
