matt-welch commented on code in PR #17340:
URL: https://github.com/apache/kafka/pull/17340#discussion_r2010980992
##########
tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java:
##########
@@ -148,6 +175,7 @@ KafkaProducer<byte[], byte[]>
createKafkaProducer(Properties props) {
Callback cb;
Review Comment:
Regarding cb and the stats objects, their scopes don't extend beyond the
start() method and the callback which gets them passed in. I tested moving
them and found no errors. Do you think that I should move their declaration in
this patch?
##########
tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java:
##########
@@ -51,6 +51,7 @@ public class ProducerPerformance {
public static final String DEFAULT_TRANSACTION_ID_PREFIX =
"performance-producer-";
public static final long DEFAULT_TRANSACTION_DURATION_MS = 3000L;
+ public static final int DEFAULT_REPORTING_INTERVAL_MS = 5000;
Review Comment:
Earlier in the PR, Chia-Ping asked to declare this variable here, probably
because it seems analogous to the DEFAULT_TRANSACTION_DURATION_MS. I think the
intent here is to have this as a parameter than can be modified for more
frequent reporting, but making it a final member of the Stats class seems
roughly equivalent to me. @kirktrue, @chia7712 where do you think these
constants should be declared?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
