mimaison commented on code in PR #18935:
URL: https://github.com/apache/kafka/pull/18935#discussion_r2010014351
##########
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##########
@@ -1380,6 +1381,14 @@ public void close() {
connectionsByCipher.close();
connectionsByClient.close();
}
+
+ public Metrics metrics() {
Review Comment:
Instead of exposing these 2 fields, I considered having a `wrapInstance()`
method but since it's pretty hard to test this class, it's not exposed by
Selector and it's "hard" to create a Selector instance, so I preferred just
adding getters.
There are other network plugins that need updating with KIP-877. So maybe
this will change depending how it goes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
