[
https://issues.apache.org/jira/browse/KAFKA-13610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937611#comment-17937611
]
Chia-Ping Tsai commented on KAFKA-13610:
----------------------------------------
It might be advisable to remove the log.cleaner.enable configuration option, as
disabling the cleaner renders compacted topics functionally meaningless. Users
can't ever be aware of the compaction is disabled when they are configuring a
compacted topic.
not sure whether there is a use case that the cleaner must be disabled. If not,
maybe we should have a KIP to discuss to remove the config
`log.cleaner.enable`. it can simplify the code as there is no "null" cleaner.
> Make log.cleaner.enable dynamically configurable
> ------------------------------------------------
>
> Key: KAFKA-13610
> URL: https://issues.apache.org/jira/browse/KAFKA-13610
> Project: Kafka
> Issue Type: Improvement
> Reporter: Colin McCabe
> Assignee: TengYao Chi
> Priority: Major
>
> It's odd that things like the number of log cleaner threads are configurable,
> but not whether it is on or off. We should make log.cleaner.enable
> dynamically configurable to close this gap.
> Additionally, from a code point of view, we should unconditionally create the
> log cleaner object in the LogManager constructor even if we never start it.
> This would simplify the code and eliminate many null checks.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
