chia7712 commented on code in PR #19177:
URL: https://github.com/apache/kafka/pull/19177#discussion_r1996313721
##########
server/src/main/java/org/apache/kafka/server/Assignment.java:
##########
@@ -57,6 +96,23 @@ boolean valid(int nodeId, MetadataImage image) {
return Replicas.contains(partition.replicas, nodeId);
}
+ @Override
+ public boolean equals(Object o) {
Review Comment:
Comparing the `successCallback` is weird as we discussed before. Could you
please check the code base to ensure this class is NOT used as Map/Set key?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
