janchilling commented on PR #19208: URL: https://github.com/apache/kafka/pull/19208#issuecomment-2724229411
Hi @cadonna @mjsax, I removed the code with the negation of _state.updater.enabled_ flag in the StreamThread#runOnceWithoutProcessingThreads method. So I removed methods StreamThread#initializeAndRestorePhase and TaskManager#tryToCompleteRestoration, since they were only called through the negation flow. Removed the assertions related to those methods in the Tests as well. Can you please verify if my approach is correct? Like should I go deep into methods of this particular flow and remove code if its only used with this particular flow( Like I removed TaskManager#tryToCompleteRestoration in the first commit) or should I only remove code of the immediate methods guarded by the _state.updater.enabled_ flag? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
