lucasbru commented on code in PR #19176:
URL: https://github.com/apache/kafka/pull/19176#discussion_r1987359087
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -238,6 +239,45 @@ public class GroupCoordinatorConfig {
public static final int SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DEFAULT =
15000;
public static final String SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DOC =
"The maximum heartbeat interval for share group members.";
+ ///
+ /// Streams group configs
+ ///
+ public static final String STREAMS_GROUP_SESSION_TIMEOUT_MS_CONFIG =
"group.streams.session.timeout.ms";
+ public static final int STREAMS_GROUP_SESSION_TIMEOUT_MS_DEFAULT = 45000;
+ public static final String STREAMS_GROUP_SESSION_TIMEOUT_MS_DOC = "The
timeout to detect client failures when using the streams group protocol.";
+
+ public static final String STREAMS_GROUP_MIN_SESSION_TIMEOUT_MS_CONFIG =
"group.streams.min.session.timeout.ms";
+ public static final int STREAMS_GROUP_MIN_SESSION_TIMEOUT_MS_DEFAULT =
45000;
+ public static final String STREAMS_GROUP_MIN_SESSION_TIMEOUT_MS_DOC = "The
minimum session timeout.";
Review Comment:
I wonder if it wouldn't be clearer if we refer to specific configurations
here:
```
"The minimum for the group-level configuration of " +
GroupConfig.STREAMS_GROUP_SESSION_TIMEOUT_MS_CONFIG
```
Same for all the other min/max configs below.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -59,6 +59,18 @@ public final class GroupConfig extends AbstractConfig {
"Negative duration is not allowed.</li>" +
"<li>anything else: throw exception to the share consumer.</li></ul>";
+ public static final String STREAMS_SESSION_TIMEOUT_MS_CONFIG =
"group.streams.session.timeout.ms";
+ public static final int STREAMS_SESSION_TIMEOUT_MS_DEFAULT = 45000;
Review Comment:
For the defaults and docs in this file, I would just reference the
`GroupCoordinatorConfig` variants instead of creating a duplicate here, like
the other group types do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
