DL1231 commented on PR #19083: URL: https://github.com/apache/kafka/pull/19083#issuecomment-2699479277
> Thanks for the contribution! I have double-checked and this is consistent with what we are doing for consumer groups today. It would be great if you could abstract it so that we don't have duplicate code, but if there isn't an obvious way I am okay with the current state Thank you for raising this point! 😊 After analyzing the differences between share group and consumer group fields, I agree that forcing abstraction at this stage might introduce hidden complexity (e.g., divergent validation rules or inconsistent field). To prioritize code clarity and maintainability, keeping the current implementation separate seems more pragmatic. If we encounter more overlapping patterns in the future, we can revisit this with a unified approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
