m1a2st commented on code in PR #19087:
URL: https://github.com/apache/kafka/pull/19087#discussion_r1978860901
##########
server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java:
##########
@@ -139,10 +139,12 @@ public class ServerLogConfigs {
public static final String CREATE_TOPIC_POLICY_CLASS_NAME_CONFIG =
"create.topic.policy.class.name";
public static final String CREATE_TOPIC_POLICY_CLASS_NAME_DOC = "The
create topic policy class that should be used for validation. The class should
" +
- "implement the
<code>org.apache.kafka.server.policy.CreateTopicPolicy</code> interface.";
+ "implement the
<code>org.apache.kafka.server.policy.CreateTopicPolicy</code> interface. " +
+ "<p>Note: In KRaft mode, this policy runs on the controller
instead of the broker.</p>";
Review Comment:
> This section talks about the functional and operational differences
between ZooKeeper mode and KRaft mode.
Given that, the statement is ok for me.
dThis section is about Kafka 4.0 configuration. If you need to mention any
Zookeeper-related changes, they should be placed in `zk2kraft.html`.
##########
server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java:
##########
@@ -139,10 +139,12 @@ public class ServerLogConfigs {
public static final String CREATE_TOPIC_POLICY_CLASS_NAME_CONFIG =
"create.topic.policy.class.name";
public static final String CREATE_TOPIC_POLICY_CLASS_NAME_DOC = "The
create topic policy class that should be used for validation. The class should
" +
- "implement the
<code>org.apache.kafka.server.policy.CreateTopicPolicy</code> interface.";
+ "implement the
<code>org.apache.kafka.server.policy.CreateTopicPolicy</code> interface. " +
+ "<p>Note: In KRaft mode, this policy runs on the controller
instead of the broker.</p>";
Review Comment:
> This section talks about the functional and operational differences
between ZooKeeper mode and KRaft mode.
Given that, the statement is ok for me.
This section is about Kafka 4.0 configuration. If you need to mention any
Zookeeper-related changes, they should be placed in `zk2kraft.html`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
