frankvicky commented on code in PR #19075:
URL: https://github.com/apache/kafka/pull/19075#discussion_r1976936643
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -1626,6 +1626,11 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
val existingTopic = new ConfigResource(ConfigResource.Type.TOPIC, topic)
client.describeConfigs(Collections.singletonList(existingTopic)).values.get(existingTopic).get()
+ val defaultTopic = new ConfigResource(ConfigResource.Type.TOPIC, "")
+ val describeResult0 =
client.describeConfigs(Collections.singletonList(defaultTopic))
Review Comment:
nit: `List.of`
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -1626,6 +1626,11 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
val existingTopic = new ConfigResource(ConfigResource.Type.TOPIC, topic)
client.describeConfigs(Collections.singletonList(existingTopic)).values.get(existingTopic).get()
+ val defaultTopic = new ConfigResource(ConfigResource.Type.TOPIC, "")
+ val describeResult0 =
client.describeConfigs(Collections.singletonList(defaultTopic))
Review Comment:
Could you please refactor the variable by using `var`?
In this way, we could eliminate confusing variables such as
`describeResultX.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
