chia7712 commented on code in PR #19027:
URL: https://github.com/apache/kafka/pull/19027#discussion_r1976697949
##########
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java:
##########
@@ -843,6 +845,17 @@ public void
testApiVersionResponseWithNotUnsupportedError() {
}
}
+ @Test
+ public void UnregisterBrokerResponseWithNotUnsupportedError() {
+ UnregisterBrokerRequest request = new
UnregisterBrokerRequest.Builder(new UnregisterBrokerRequestData())
+ .build((short) 0);
+ UnregisterBrokerResponse response = request.getErrorResponse(0,
Errors.INVALID_REQUEST.exception());
Review Comment:
Could you please create a exception with custom error message? otherwise,
this test does not ensure the custom exception is added into the response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
