clarkwtc commented on code in PR #19070:
URL: https://github.com/apache/kafka/pull/19070#discussion_r1976669347
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -385,6 +388,10 @@ private ApiError validateAlterConfig(
new ApiError(INVALID_CONFIG, "Cluster-level " +
MIN_IN_SYNC_REPLICAS_CONFIG +
" cannot be removed while ELR is enabled.");
+ private static final ApiError DISALLOWED_CONFIG_VALUE_SIZE_ERROR =
+ new ApiError(INVALID_CONFIG, String.format("The configuration
value cannot be added because " +
+ "it exceeds the maximum value size of %d bytes.",
Short.MAX_VALUE));
Review Comment:
@frankvicky
I originally thought `String.format` would be more readable than using the
appending string.
Sure, we should follow the code style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
