[ 
https://issues.apache.org/jira/browse/KAFKA-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734850#comment-16734850
 ] 

ASF GitHub Bot commented on KAFKA-5056:
---------------------------------------

hachikuji commented on pull request #2843: KAFKA-5056: Add shuffling of 
FetchRequest requestInfo back to old consumer
URL: https://github.com/apache/kafka/pull/2843
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Shuffling of partitions in old consumer fetch requests removed
> --------------------------------------------------------------
>
>                 Key: KAFKA-5056
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5056
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.10.1.0
>            Reporter: Todd Palino
>            Assignee: Todd Palino
>            Priority: Major
>
> [KIP-74|https://cwiki.apache.org/confluence/display/KAFKA/KIP-74%3A+Add+Fetch+Response+Size+Limit+in+Bytes]
>  deprecated the constructor to {{FetchRequest}} which shuffles the 
> {{requestInfo}} parameter, in favor of round robin reordering logic added to 
> the replica fetcher and the consumer API. However, this was not added to the 
> old consumer {{ConsumerFetcherThread}}, which has resulted in unfair 
> partition fetching since 0.10.1.
> In order to maintain the old consumer, we need to add the removed shuffle to 
> {{buildFetchRequest}} as the topic-partition list for each {{FetchRequest}} 
> is composed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to