jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1968145822
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -1786,8 +1788,16 @@ private boolean handleFetchResponse(
}
} else {
Records records =
FetchResponse.recordsOrFail(partitionResponse);
- if (records.sizeInBytes() > 0) {
+ try {
+ // TODO: make sure to test corrupted records in kafka
metadata log
appendAsFollower(records);
+ } catch (CorruptRecordException | InvalidRecordException e) {
+ // TODO: this should log up to 265 bytes from the records
Review Comment:
Done.
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -1786,8 +1788,16 @@ private boolean handleFetchResponse(
}
} else {
Records records =
FetchResponse.recordsOrFail(partitionResponse);
- if (records.sizeInBytes() > 0) {
+ try {
+ // TODO: make sure to test corrupted records in kafka
metadata log
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
