FrankYang0529 commented on code in PR #18387:
URL: https://github.com/apache/kafka/pull/18387#discussion_r1967862812
##########
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##########
@@ -1230,6 +1230,44 @@ class KafkaConfigTest {
KafkaConfig.fromProps(props)
}
+ @Test
+ def
testImplicitAllBindingControllerListenersCanBeAdvertisedForKRaftController():
Unit = {
+ val props = new Properties()
+ props.setProperty(KRaftConfigs.PROCESS_ROLES_CONFIG, "controller")
+ val listeners = "CONTROLLER://:9093"
+ props.setProperty(SocketServerConfigs.LISTENERS_CONFIG, listeners)
+ props.setProperty(SocketServerConfigs.ADVERTISED_LISTENERS_CONFIG,
listeners) // explicitly setting it in KRaft
Review Comment:
@jsancio, thanks for the review. I add two cases for broker:
* testImplicitAllBindingListenersCanBeAdvertisedForBroker
* testExplicitAllBindingListenersCannotBeUsedForBroker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
