cadonna commented on code in PR #18981:
URL: https://github.com/apache/kafka/pull/18981#discussion_r1967719357


##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -10040,6 +10040,86 @@ class KafkaApisTest extends Logging {
     assertEquals("Use of Kafka internal topics 
__consumer_offsets,__transaction_state,__share_group_state in a Kafka Streams 
topology is prohibited.", response.data.errorMessage())
   }
 
+  @Test
+  def testStreamsGroupHeartbeatRequestMissingTopics(): Unit = {

Review Comment:
   This name is a bit misleading. I thought an exception should be thrown 
verified in this test. What about 
`testStreamsGroupHeartbeatRequestWithInternalTopicsToCreate()`
   
   Please also rename the test below accordingly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to