TaiJuWu commented on code in PR #18850: URL: https://github.com/apache/kafka/pull/18850#discussion_r1959701194
########## clients/src/main/java/org/apache/kafka/clients/consumer/ShareConsumerConfig.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.clients.consumer; + +import org.apache.kafka.common.config.ConfigException; +import org.apache.kafka.common.utils.Utils; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.Properties; + + +public class ShareConsumerConfig extends ConsumerConfig { + /** + * A list of configuration keys not supported for SHARE protocol. + */ + private static final List<String> SHARE_PROTOCOL_UNSUPPORTED_CONFIGS = List.of( + ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, Review Comment: Pardon me. I found there are two similar descriptions in KIP, maybe they are the same items since I can't find `protocol.type` in `ConsumerConfig` ``` protocol.type : this configuration is used to select the group protocol used for KafkaConsumer group.protocol : this is used by KafkaConsumer to select between the classic and modern consumer group rebalance protocols ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
